Prometheus Exporter - added total energy & auto cleanup, renamed Exports #1007
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@cianc |
cianc
reviewed
Dec 17, 2025
Added auto cleanup after shutdown from push gateway Renamed attributes
benoit-cty
force-pushed
the
Prometheus_Exporter_Update
branch
from
3fe1ccb to
e8419c3
Compare
Co-authored-by: cianc <[email protected]>
Contributor
|
Hello, I've:
Is it ok for you ? |
Contributor
Author
|
Thanks for your help. The changes you make look fine for me. |
Contributor
Author
|
It will take couple of days to clear out jobs running with another branch, but until now everything that was running this branch worked fine. I have no objections to merging this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added auto cleanup after shutdown from push gateway
Renamed several attributes and fixed kw to kwh
Added total power to avoid race conditions with push gateway and prometheus crawler
Related Issue
Implemented #975
Motivation and Context
Race conditions between push gateway updates and crawling via promethus accumulate over time and skew the total over time
Push gateway does not automatically remove entries after termination of the program, therefore the last value is kept until manually removed. For cluster environments this is not feasible
How Has This Been Tested?
The changes are extracted from the fork currently running in our cluster environment and we monitor the jobs with grafana
I am currently investigating methods to improve the autoclean
Types of changes
What types of changes does your code introduce? Put an
xin all the boxes that apply:Checklist:
Go over all the following points, and put an
xin all the boxes that apply.